spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgummelt <...@git.apache.org>
Subject [GitHub] spark pull request #14275: [SPARK-16637] Unified containerizer
Date Thu, 21 Jul 2016 17:14:18 GMT
Github user mgummelt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14275#discussion_r71746880
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/ui/DriverPage.scala ---
    @@ -50,7 +50,7 @@ private[ui] class DriverPage(parent: MesosClusterUI) extends WebUIPage("driver")
         val driverDescription = Iterable.apply(driverState.description)
         val submissionState = Iterable.apply(driverState.submissionState)
         val command = Iterable.apply(driverState.description.command)
    -    val schedulerProperties = Iterable.apply(driverState.description.schedulerProperties)
    +    val schedulerProperties = Iterable.apply(driverState.description.sc.getAll.toMap)
    --- End diff --
    
    `conf` is still namespaced under `driverState`, so I think it's still just as clear that
these are driver properties.  In fact, maybe even moreso, since "scheduler" is ambiguous,
as both the dispatcher and the driver are schedulers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message