spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #14240: [SPARK-16594] [SQL] Remove Physical Plan Differen...
Date Thu, 21 Jul 2016 01:24:19 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14240#discussion_r71634679
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/PrunedScanSuite.scala ---
    @@ -114,16 +114,15 @@ class PrunedScanSuite extends DataSourceTest with SharedSQLContext
{
       testPruning("SELECT * FROM oneToTenPruned", "a", "b")
       testPruning("SELECT a, b FROM oneToTenPruned", "a", "b")
       testPruning("SELECT b, a FROM oneToTenPruned", "b", "a")
    -  testPruning("SELECT b, b FROM oneToTenPruned", "b")
    +  testPruning("SELECT b, b FROM oneToTenPruned", "b", "b")
    +  testPruning("SELECT b as alias_b, b FROM oneToTenPruned", "b")
    --- End diff --
    
    after your PR, will data source table return only one column for this case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message