spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #14242: Add a comment
Date Wed, 20 Jul 2016 10:35:37 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14242#discussion_r71501991
  
    --- Diff: examples/src/main/scala/org/apache/spark/examples/SparkKMeans.scala ---
    @@ -33,7 +33,6 @@ object SparkKMeans {
       def parseVector(line: String): Vector[Double] = {
         DenseVector(line.split(' ').map(_.toDouble))
       }
    -
    --- End diff --
    
    Actually, I guess this newline does not have to be removed because it seems, in 
     [scala-style-guide#blank-lines-vertical-whitespace](https://github.com/databricks/scala-style-guide#blank-lines-vertical-whitespace),
    >A single blank line appears:
    >Between consecutive members (or initializers) of a class: fields, constructors, methods,
nested classes, static initializers, instance initializers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message