spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #14086: [SPARK-16463][SQL] Support `truncate` option in O...
Date Wed, 20 Jul 2016 06:16:00 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14086#discussion_r71470834
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
    @@ -419,8 +422,13 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
           }
     
           if (mode == SaveMode.Overwrite && tableExists) {
    -        JdbcUtils.dropTable(conn, table)
    -        tableExists = false
    +        if (extraOptions.getOrElse("truncate", "false").toBoolean &&
    +            JdbcUtils.isCascadingTruncateTable(url) == Some(false)) {
    +          JdbcUtils.truncateTable(conn, table)
    --- End diff --
    
    I see. Then, the current implementation looks good to me. 
    
    @dongjoon-hyun Could you summarize the previous discussion and design decision we made?
Document them in the PR description. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message