spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...
Date Tue, 19 Jul 2016 20:48:58 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14155#discussion_r71420308
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala ---
    @@ -42,8 +41,7 @@ object HiveSerDe {
             HiveSerDe(
               inputFormat = Option("org.apache.hadoop.hive.ql.io.RCFileInputFormat"),
               outputFormat = Option("org.apache.hadoop.hive.ql.io.RCFileOutputFormat"),
    -          serde = Option(conf.getConfString("hive.default.rcfile.serde",
    -            "org.apache.hadoop.hive.serde2.columnar.LazyBinaryColumnarSerDe"))),
    +          serde = Option("org.apache.hadoop.hive.serde2.columnar.LazyBinaryColumnarSerDe")),
    --- End diff --
    
    Below are two related Hive JIRAs:
     - https://issues.apache.org/jira/browse/HIVE-4475
     - https://issues.apache.org/jira/browse/HIVE-6210
    
     This change has an external impact. I am not sure whether we can remove this.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message