spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <>
Subject [GitHub] spark pull request #14251: [SPARK-16602][SQL] `Nvl` function should support ...
Date Tue, 19 Jul 2016 06:08:45 GMT
Github user dongjoon-hyun commented on a diff in the pull request:
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
    @@ -100,7 +100,8 @@ object TypeCoercion {
       /** Similar to [[findTightestCommonType]], but can promote all the way to StringType.
    -  private def findTightestCommonTypeToString(left: DataType, right: DataType): Option[DataType]
= {
    +  private[catalyst] def findTightestCommonTypeToString(left: DataType, right: DataType)
    --- End diff --
    Oh, sure. I will make this `public`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message