spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQL...
Date Mon, 18 Jul 2016 01:57:27 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14235#discussion_r71094916
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
    @@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extends SQLBuilderTest with SQLTestUtils
{
         }
       }
     
    -  private def checkHiveQl(hiveQl: String): Unit = {
    -    val df = sql(hiveQl)
    +  // Used for generating new query answer files by saving
    +  private val saveQuery = false
    +
    +  /**
    +   * Compare the generated SQL with the expected answer string.
    +   * Note that there exists a normalization for both arguments for the convenience.
    +   * - Remove the id from the generated attributes, e.g., `gen_attr_1` -> `gen_attr`.
    +   */
    +  private def checkSQLStructure(originalSQL: String, convertedSQL: String, answerFile:
String) = {
    +    val normalizedGenSQL = convertedSQL.replaceAll("`gen_attr_\\d+`", "`gen_attr`")
    +    if (answerFile != null) {
    +      val path = s"src/test/resources/sqlgen/$answerFile.sql"
    --- End diff --
    
    No problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message