spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <>
Subject [GitHub] spark pull request #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQL...
Date Sun, 17 Jul 2016 23:37:35 GMT
Github user rxin commented on a diff in the pull request:
    --- Diff: sql/hive/src/test/resources/sqlgen/agg1.sql ---
    @@ -0,0 +1,3 @@
    +SELECT COUNT(value) FROM parquet_t1 GROUP BY key HAVING MAX(key) > 0
    +SELECT `gen_attr` AS `count(value)` FROM (SELECT `gen_attr` FROM (SELECT count(`gen_attr`)
AS `gen_attr`, max(`gen_attr`) AS `gen_attr` FROM (SELECT `key` AS `gen_attr`, `value` AS
`gen_attr` FROM `default`.`parquet_t1`) AS gen_subquery_0 GROUP BY `gen_attr` HAVING (`gen_attr`
> CAST(0 AS BIGINT))) AS gen_subquery_1) AS gen_subquery_2
    --- End diff --
    can you add a new line to the end? this little red thing on github is annoying

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message