spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request #14223: [SPARK-10614][CORE] Change SystemClock to derive ...
Date Sat, 16 Jul 2016 20:25:05 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14223#discussion_r71071394
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
    @@ -17,11 +17,21 @@
     
     package org.apache.spark.util
     
    +import java.util.concurrent.TimeUnit
    +
     /**
      * An interface to represent clocks, so that they can be mocked out in unit tests.
      */
     private[spark] trait Clock {
    +  /** @return the time in milliseconds */
       def getTimeMillis(): Long
    +
    +  /**
    +   * Wait until a clock's view of current time reaches the specified target time.
    +   *
    +   * @param targetTime block until the current time is at least this value
    +   * @return clock's view of current time when the wait has completed
    +   */
       def waitTillTime(targetTime: Long): Long
    --- End diff --
    
    what's the unit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message