spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries
Date Fri, 15 Jul 2016 21:15:40 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14132#discussion_r71041967
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -1774,6 +1775,34 @@ class Analyzer(
       }
     
       /**
    +   * Substitute Hints.
    +   * - BROADCAST/BROADCASTJOIN/MAPJOIN match the closest table with the given name parameters.
    +   */
    +  object SubstituteHints extends Rule[LogicalPlan] {
    +    def apply(plan: LogicalPlan): LogicalPlan = plan transform {
    +      case logical: LogicalPlan => logical transformDown {
    +        case h @ Hint(name, parameters, child)
    +            if Seq("BROADCAST", "BROADCASTJOIN", "MAPJOIN").contains(name.toUpperCase)
=>
    +          var resolvedChild = child
    +          for (table <- parameters) {
    +            var stop = false
    +            resolvedChild = child.transformDown {
    --- End diff --
    
    Could you give me a little bit more hint? :)
    Is the naming `resolvedChild`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message