spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark issue #14170: [SPARK-16531][SQL][TEST] Remove timezone setting from Da...
Date Thu, 14 Jul 2016 18:14:00 GMT
Github user marmbrus commented on the issue:

    https://github.com/apache/spark/pull/14170
  
    Oh, I see what you are saying, although I'm not sure I agree with the conclusion.  Given
that tests can run in parallel I don't think you actually want to toggle back and forth between
timezones.  I actually think that was causing the flakeyness we are trying to fix.
    
    In contrast, setting the default timezone to something fixed across all suites in Spark
is idempotent.  So, if any suite that cares about the default timezone just sets it to `LA`
you should be fine even in the face of concurrency.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message