spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd ...
Date Wed, 13 Jul 2016 21:02:36 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14173#discussion_r70708101
  
    --- Diff: R/pkg/R/column.R ---
    @@ -44,6 +44,9 @@ setMethod("initialize", "Column", function(.Object, jc) {
       .Object
     })
     
    +#' @rdname column
    +#' @name column
    +#' @aliases column,jobj-method
    --- End diff --
    
    Yeah thats an interesting point - The reason this comes up is that we export the `column(character)`
function in https://github.com/apache/spark/blob/b4baf086ca380a46d953f2710184ad9eee3a045e/R/pkg/R/functions.R#L273
and if we export a generic then all implementations of that generic automatically seem to
get exported. This is the same issue as [SPARK-16519](https://issues.apache.org/jira/browse/SPARK-16519)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message