spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nblintao <...@git.apache.org>
Subject [GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...
Date Wed, 13 Jul 2016 04:20:47 GMT
Github user nblintao commented on the issue:

    https://github.com/apache/spark/pull/14158
  
    **In the commit above, I made three adjustments:**
    
    1. If the query has no related query text, show a blank in that field.
    
    1. If there is no query in the table has a query text, not show the column.
    
    1. If the query text is too long (i.e. longer than 140 chars), show the short abstract
and display the full version on demand.
    
    **A snapshot of the SQL Tab:**
    ![longsqltext](https://cloud.githubusercontent.com/assets/5558370/16790563/9c4e638c-487c-11e6-9478-e3e4c804f182.png)
    (The detailed SQL text for Query 4 shown after clicking "+more")
    
    **The following need to be discussed and implemented (suggested by @yhuai):**
    
    1. Add a ToolTip on "SQL Text", saying "Blank if the query is not issued by SQL" (Please
help check this sentence if you are a native English speaker).
    
    2. For now, we could show the abstract of the string at the front end. But we still need
to truncate the query texts which are toooooo long (maybe longer than 1000 bytes?). This is
to avoid downing browsers or web UI servers by running out of memory.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message