spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #13704: [SPARK-15985][SQL] Reduce runtime overhead of a p...
Date Mon, 11 Jul 2016 10:30:01 GMT
Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13704#discussion_r70234587
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
    @@ -1441,6 +1441,26 @@ object PushPredicateThroughJoin extends Rule[LogicalPlan] with
PredicateHelper {
     object SimplifyCasts extends Rule[LogicalPlan] {
       def apply(plan: LogicalPlan): LogicalPlan = plan transformAllExpressions {
         case Cast(e, dataType) if e.dataType == dataType => e
    +    case Cast(e, dataType) =>
    +      (e.dataType, dataType) match {
    +        case (fromDt: ArrayType, toDt: ArrayType) =>
    --- End diff --
    
    thanks, I like this simple one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message