spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #14075: [SPARK-16401] [SQL] Data Source API: Enable Exten...
Date Fri, 08 Jul 2016 15:44:17 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14075#discussion_r70095195
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
    @@ -82,6 +82,34 @@ class DefaultSource
       }
     }
     
    +/** Dummy provider with only RelationProvider and CreatableRelationProvider. */
    +class DefaultSourceWithoutUserSpecifiedSchema
    +  extends RelationProvider
    +  with CreatableRelationProvider {
    +
    +  case class FakeRelation(sqlContext: SQLContext) extends BaseRelation {
    +    override def schema: StructType = StructType(Seq(StructField("a", StringType)))
    +  }
    +
    +  override def createRelation(
    +      sqlContext: SQLContext,
    +      parameters: Map[String, String]): BaseRelation = {
    +    LastOptions.parameters = parameters
    +    LastOptions.schema = None
    --- End diff --
    
    That is from the another default source. It is useless in this test case. Let me clean
them. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message