spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tnachen <...@git.apache.org>
Subject [GitHub] spark pull request #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse...
Date Wed, 06 Jul 2016 05:26:08 GMT
Github user tnachen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13950#discussion_r69676891
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
    @@ -186,6 +188,67 @@ private[spark] object JettyUtils extends Logging {
         contextHandler
       }
     
    +  /** Create a handler for proxying request to Workers and Application Drivers */
    +  def createProxyHandler(
    +      prefix: String,
    +      target: String): ServletContextHandler = {
    +    val servlet = new ProxyServlet {
    +      override def rewriteTarget(request: HttpServletRequest): String = {
    +        val path = request.getRequestURI();
    +        if (!path.startsWith(prefix)) return null
    +
    +        val uri = new StringBuilder(target)
    +        if (target.endsWith("/")) uri.setLength(uri.length() - 1)
    +        val rest = path.substring(prefix.length())
    +        if (!rest.isEmpty())
    +        {
    --- End diff --
    
    Move { to previous line 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message