spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #13990: [SPARK-16287][SQL] Implement str_to_map SQL funct...
Date Wed, 06 Jul 2016 00:23:09 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13990#discussion_r69659952
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
    @@ -393,3 +393,71 @@ case class CreateNamedStructUnsafe(children: Seq[Expression]) extends
Expression
     
       override def prettyName: String = "named_struct_unsafe"
     }
    +
    +/**
    + * Creates a map after splitting the input text into key/value pairs using delimeters
    + */
    +@ExpressionDescription(
    +  usage = """_FUNC_(text[, pairDelim, keyValueDelim]) - Creates a map after splitting
the text into
    +    key/value pairs using delimiters.
    +    Default delimiters are ',' for pairDelim and '=' for keyValueDelim.""")
    +case class StringToMap(text: Expression, pairDelim: Expression, keyValueDelim: Expression)
    +  extends TernaryExpression with ExpectsInputTypes {
    +
    +  def this(child: Expression) = {
    +    this(child, Literal(","), Literal("="))
    +  }
    +
    +  override def children: Seq[Expression] = Seq(text, pairDelim, keyValueDelim)
    +
    +  override def inputTypes: Seq[AbstractDataType] = Seq(StringType, StringType, StringType)
    +
    +  override def dataType: DataType = MapType(StringType, StringType, valueContainsNull
= false)
    +
    +  override def nullSafeEval(str: Any, delim1: Any, delim2: Any): Any = {
    +    val array = str.asInstanceOf[UTF8String]
    +      .split(delim1.asInstanceOf[UTF8String], -1)
    +      .map{_.split(delim2.asInstanceOf[UTF8String], 2)}
    +
    +    ArrayBasedMapData(array.map(_(0)), array.map(_(1))).asInstanceOf[MapData]
    --- End diff --
    
    seems unnecessary `asInstanceOf`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message