spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request #13708: [SPARK-15591] [WEBUI] Paginate Stage Table in Sta...
Date Tue, 05 Jul 2016 17:32:21 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13708#discussion_r69604607
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala ---
    @@ -38,22 +38,20 @@ private[ui] class AllStagesPage(parent: StagesTab) extends WebUIPage("")
{
           val numCompletedStages = listener.numCompletedStages
           val failedStages = listener.failedStages.reverse.toSeq
           val numFailedStages = listener.numFailedStages
    -      val now = System.currentTimeMillis
    +      val subPath = "stages"
     
           val activeStagesTable =
    -        new StageTableBase(activeStages.sortBy(_.submissionTime).reverse,
    -          parent.basePath, parent.progressListener, isFairScheduler = parent.isFairScheduler,
    -          killEnabled = parent.killEnabled)
    +        new StageTableBase(request, activeStages, "activeStage", parent.basePath, subPath,
    +          parent.progressListener, parent.isFairScheduler, parent.killEnabled, false)
           val pendingStagesTable =
    -        new StageTableBase(pendingStages.sortBy(_.submissionTime).reverse,
    -          parent.basePath, parent.progressListener, isFairScheduler = parent.isFairScheduler,
    -          killEnabled = false)
    +        new StageTableBase(request, pendingStages, "pendingStage", parent.basePath, subPath,
    +          parent.progressListener, parent.isFairScheduler, false, false)
    --- End diff --
    
    nit: could you add the parameter names back to improve the readability?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message