spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #13680: [SPARK-15962][SQL] Introduce implementation with ...
Date Mon, 04 Jul 2016 18:11:31 GMT
Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13680#discussion_r69483637
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnsafeArrayDataBenchmark.scala
---
    @@ -0,0 +1,256 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.benchmark
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.sql.catalyst.encoders.ExpressionEncoder
    +import org.apache.spark.sql.catalyst.expressions.{UnsafeArrayData, UnsafeRow}
    +import org.apache.spark.sql.catalyst.expressions.codegen.{BufferHolder, UnsafeArrayWriter}
    +import org.apache.spark.unsafe.Platform
    +import org.apache.spark.util.Benchmark
    +
    +/**
    + * Benchmark [[UnsafeArrayDataBenchmark]] for UnsafeArrayData
    + * To run this:
    + *  build/sbt "sql/test-only *benchmark.UnsafeArrayDataBenchmark"
    + *
    + * Benchmarks in this file are skipped in normal builds.
    + */
    +class UnsafeArrayDataBenchmark extends BenchmarkBase {
    +
    +  def calculateHeaderPortionInBytes(count: Int) : Int = {
    +    // Use this assignment for SPARK-15962
    +    // val size = 4 + 4 * count
    +    val size = UnsafeArrayData.calculateHeaderPortionInBytes(count)
    +    size
    +  }
    +
    +  def readUnsafeArray(iters: Int): Unit = {
    +    val count = 1024 * 1024 * 16
    +
    +    var intResult: Int = 0
    +    val intBuffer = new Array[Int](count)
    +    val intEncoder = ExpressionEncoder[Array[Int]].resolveAndBind()
    +    val intInternalRow = intEncoder.toRow(intBuffer)
    +    val intUnsafeArray = intInternalRow.getArray(0)
    +    val readIntArray = { i: Int =>
    +      var n = 0
    +      while (n < iters) {
    +        val len = intUnsafeArray.numElements
    +        var sum = 0.toInt
    +        var i = 0
    +        while (i < len) {
    +          sum += intUnsafeArray.getInt(i)
    +          i += 1
    +        }
    +        intResult = sum
    +        n += 1
    +      }
    +    }
    +
    +    var doubleResult: Double = 0
    +    val doubleBuffer = new Array[Double](count)
    +    val doubleEncoder = ExpressionEncoder[Array[Double]].resolveAndBind()
    +    val doubleInternalRow = doubleEncoder.toRow(doubleBuffer)
    +    val doubleUnsafeArray = doubleInternalRow.getArray(0)
    +    val readDoubleArray = { i: Int =>
    +      var n = 0
    +      while (n < iters) {
    +        val len = doubleUnsafeArray.numElements
    +        var sum = 0.toDouble
    +        var i = 0
    +        while (i < len) {
    +          sum += doubleUnsafeArray.getDouble(i)
    +          i += 1
    +        }
    +        doubleResult = sum
    +        n += 1
    +      }
    +    }
    +
    +    val benchmark = new Benchmark("Read UnsafeArrayData", count * iters)
    +    benchmark.addCase("Int")(readIntArray)
    +    benchmark.addCase("Double")(readDoubleArray)
    +    benchmark.run
    +    /*
    +    Java HotSpot(TM) 64-Bit Server VM 1.8.0_92-b14 on Mac OS X 10.10.4
    +    Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
    +
    +    Read UnsafeArrayData:                    Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)
  Relative
    +    ------------------------------------------------------------------------------------------------
    +    Int                                            281 /  296        597.5          
1.7       1.0X
    +    Double                                         298 /  301        562.3          
1.8       0.9X
    +    */
    +  }
    +
    +  def writeUnsafeArray(iters: Int): Unit = {
    +    val count = 1024 * 1024 * 16
    +
    +    val intUnsafeRow = new UnsafeRow(1)
    +    val intUnsafeArrayWriter = new UnsafeArrayWriter
    +    val intBufferHolder = new BufferHolder(intUnsafeRow, 64)
    +    intBufferHolder.reset()
    +    intUnsafeArrayWriter.initialize(intBufferHolder, count, 4)
    +    val intCursor = intBufferHolder.cursor
    +    val writeIntArray = { i: Int =>
    +      var n = 0
    +      while (n < iters) {
    +        intBufferHolder.cursor = intCursor
    +        val len = count
    +        var i = 0
    +        while (i < len) {
    +          intUnsafeArrayWriter.write(i, 0.toInt)
    +          i += 1
    +        }
    +        n += 1
    +      }
    +    }
    +
    +    val doubleUnsafeRow = new UnsafeRow(1)
    +    val doubleUnsafeArrayWriter = new UnsafeArrayWriter
    +    val doubleBufferHolder = new BufferHolder(doubleUnsafeRow, 64)
    +    doubleBufferHolder.reset()
    +    doubleUnsafeArrayWriter.initialize(doubleBufferHolder, count, 8)
    +    val doubleCursor = doubleBufferHolder.cursor
    +    val writeDoubleArray = { i: Int =>
    +      var n = 0
    +      while (n < iters) {
    +        doubleBufferHolder.cursor = doubleCursor
    +        val len = count
    +        var i = 0
    +        while (i < len) {
    +          doubleUnsafeArrayWriter.write(i, 0.toDouble)
    +          i += 1
    +        }
    +        n += 1
    +      }
    +    }
    +
    +    val benchmark = new Benchmark("Write UnsafeArrayData", count * iters)
    +    benchmark.addCase("Int")(writeIntArray)
    +    benchmark.addCase("Double")(writeDoubleArray)
    +    benchmark.run
    +    /*
    +    Java HotSpot(TM) 64-Bit Server VM 1.8.0_92-b14 on Mac OS X 10.10.4
    +    Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
    +
    +    Write UnsafeArrayData:                   Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)
  Relative
    +    ------------------------------------------------------------------------------------------------
    +    Int                                             82 /   85       2056.9          
0.5       1.0X
    +    Double                                         139 /  144       1207.1          
0.8       0.6X
    +    */
    +  }
    +
    +  def getPrimitiveArray(iters: Int): Unit = {
    +    val count = 1024 * 1024 * 12
    +
    +    val intUnsafeArray = new UnsafeArrayData
    +    val intSize = calculateHeaderPortionInBytes(count) + 4 * count
    +    val intBuffer = new Array[Byte](intSize)
    +    Platform.putInt(intBuffer, Platform.BYTE_ARRAY_OFFSET, count)
    +    intUnsafeArray.pointTo(intBuffer, Platform.BYTE_ARRAY_OFFSET, intSize)
    +    var intPrimitiveArray: Array[Int] = null
    +    val readIntArray = { i: Int =>
    +      var n = 0
    +      while (n < iters) {
    +        intPrimitiveArray = intUnsafeArray.toIntArray
    +        n += 1
    +      }
    +    }
    +
    +    val doubleUnsafeArray = new UnsafeArrayData
    +    val doubleSize = calculateHeaderPortionInBytes(count) + 8 * count
    +    val doubleBuffer = new Array[Byte](doubleSize)
    +    Platform.putInt(doubleBuffer, Platform.BYTE_ARRAY_OFFSET, count)
    +    doubleUnsafeArray.pointTo(doubleBuffer, Platform.BYTE_ARRAY_OFFSET, doubleSize)
    +    var doublePrimitiveArray: Array[Double] = null
    +    val readDoubleArray = { i: Int =>
    +      var n = 0
    +      while (n < iters) {
    +        doublePrimitiveArray = doubleUnsafeArray.toDoubleArray
    +        n += 1
    +      }
    +    }
    +
    +    val benchmark = new Benchmark("Get primitive array from UnsafeArrayData", count *
iters)
    +    benchmark.addCase("Int")(readIntArray)
    +    benchmark.addCase("Double")(readDoubleArray)
    +    benchmark.run
    +    /*
    +    Java HotSpot(TM) 64-Bit Server VM 1.8.0_92-b14 on Mac OS X 10.10.4
    +    Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
    +
    +    Get primitive array from UnsafeArrayData: Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)
 Relative
    +    ------------------------------------------------------------------------------------------------
    +    Int                                            100 /  176        632.1          
1.6       1.0X
    +    Double                                         267 /  334        236.0          
4.2       0.4X
    +    */
    +  }
    +
    +  def putPrimitiveArray(iters: Int): Unit = {
    +    val count = 1024 * 1024 * 12
    +
    +    val intPrimitiveArray: Array[Int] = new Array[Int](count)
    --- End diff --
    
    done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message