spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #14044: [SPARK-16360][SQL] Speed up SQL query performance...
Date Mon, 04 Jul 2016 14:43:38 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14044#discussion_r69467305
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -62,7 +62,7 @@ private[sql] object Dataset {
       def ofRows(sparkSession: SparkSession, logicalPlan: LogicalPlan): DataFrame = {
         val qe = sparkSession.sessionState.executePlan(logicalPlan)
         qe.assertAnalyzed()
    -    new Dataset[Row](sparkSession, logicalPlan, RowEncoder(qe.analyzed.schema))
    +    new Dataset[Row](sparkSession, qe, RowEncoder(qe.analyzed.schema), skipAnalysis =
true)
    --- End diff --
    
    how about we remove the `qe.assertAnalyzed()` in `ofRows`? Then we don't need the `skipAnalysis`
flag.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message