spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request #13957: [SPARK-16114] [SQL] structured streaming event ti...
Date Fri, 01 Jul 2016 20:37:16 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13957#discussion_r69352799
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
    @@ -47,7 +52,7 @@ class TextSocketSource(host: String, port: Int, sqlContext: SQLContext)
       private var readThread: Thread = null
     
       @GuardedBy("this")
    -  private var lines = new ArrayBuffer[String]
    +  private var lines = new ArrayBuffer[(String, String)]
    --- End diff --
    
    why cant you store it in the java.sql.time form?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message