spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From janplus <...@git.apache.org>
Subject [GitHub] spark issue #14008: [SPARK-16281][SQL] Implement parse_url SQL function
Date Fri, 01 Jul 2016 13:14:05 GMT
Github user janplus commented on the issue:

    https://github.com/apache/spark/pull/14008
  
    @rxin and @dongjoon-hyun Thanks for your review.
    I have add a new commit which does following things:
    
    1. Put `parse_url` function in the right order.
    2. Use `""" """` instead of `+` in `extended` part to work with Scala 2.1.
    3. Remove unnecessary `lazy`s.
    4. Correct `REGEXPREFIX` and add a new null test case.
    5. Use `NonFatal(_)` instead of the specified exception.
    6. Fix the indentation problems.
    
    I have tried to not use varargs, but a separate constructor that accept two args does
not help. As there isn't a magic key to make `parse_url(url, partToExtract, magic key)` to
be treated as `parse_url(url, partToExtract)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message