Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: cloud-fan <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-13680-spark@git.apache.org>
In-Reply-To: <git-pr-13680-spark@git.apache.org>
Subject: [GitHub] spark pull request #13680: [SPARK-15962][SQL] Introduce
 implementation with ...
Content-Type: text/plain
Message-Id: <20160628123335.D4F78E08FE@git1-us-west.apache.org>
Date: Tue, 28 Jun 2016 12:33:35 +0000 (UTC)

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13680#discussion_r68747162
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java ---
    @@ -331,6 +299,10 @@ public void writeTo(ByteBuffer buffer) {
         buffer.position(pos + sizeInBytes);
       }
     
    +  // This `hashCode` computation could consume much processor time for large data.
    --- End diff --
    
    comment at wrong place?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org