Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 081C5194DB for ; Wed, 22 Jun 2016 15:06:10 +0000 (UTC) Received: (qmail 43467 invoked by uid 500); 22 Jun 2016 15:06:10 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 43460 invoked by uid 500); 22 Jun 2016 15:06:09 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 43449 invoked by uid 99); 22 Jun 2016 15:06:09 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jun 2016 15:06:09 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 88EB6DFEDA; Wed, 22 Jun 2016 15:06:09 +0000 (UTC) From: maropu To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark issue #13847: [SPARK-16135][SQL] Implement hashCode and euqals in Unsa... Content-Type: text/plain Message-Id: <20160622150609.88EB6DFEDA@git1-us-west.apache.org> Date: Wed, 22 Jun 2016 15:06:09 +0000 (UTC) Github user maropu commented on the issue: https://github.com/apache/spark/pull/13847 It seems `UnsafeArrayData` already has its own `equals` and hashCode`. Currently, spark doesn't compare unsafe MapData though, I think this might cause implicit bugs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org