Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: tdas <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-13730-spark@git.apache.org>
In-Reply-To: <git-pr-13730-spark@git.apache.org>
Subject: [GitHub] spark pull request #13730: [SPARK-16006][SQL] Attemping to
 write empty DataF...
Content-Type: text/plain
Message-Id: <20160617084504.BD243E049D@git1-us-west.apache.org>
Date: Fri, 17 Jun 2016 08:45:04 +0000 (UTC)

Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13730#discussion_r67477579
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala ---
    @@ -351,8 +354,10 @@ private[sql] object PartitioningUtils {
           }
         }
     
    -    if (partitionColumns.size == schema.fields.size) {
    -      throw new AnalysisException(s"Cannot use all columns for partition columns")
    +    if (schema.fields.isEmpty) {
    --- End diff --
    
    Its weird that a check like this is in the PartitioningUtils. This check seems nothing to do with partitioning, as its basically certain file formats that do not support writing a DF with no columns. Is there somewhere earlier where you can check this? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org