Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: lw-lin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-13575-spark@git.apache.org>
In-Reply-To: <git-pr-13575-spark@git.apache.org>
Subject: [GitHub] spark pull request #13575: [SPARK-15472][SQL] Add support
 for writing in `cs...
Content-Type: text/plain
Message-Id: <20160609154802.DDBEEDFDEF@git1-us-west.apache.org>
Date: Thu,  9 Jun 2016 15:48:02 +0000 (UTC)

Github user lw-lin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13575#discussion_r66467191
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala ---
    @@ -120,24 +109,31 @@ class TextFileFormat extends FileFormat with DataSourceRegister {
           }
         }
       }
    +
    +  override def buildWriter(
    +      sqlContext: SQLContext,
    +      dataSchema: StructType,
    +      options: Map[String, String]): OutputWriterFactory = {
    +    verifySchema(dataSchema)
    +    new StreamingTextOutputWriterFactory(
    +      sqlContext.conf,
    +      dataSchema,
    +      sqlContext.sparkContext.hadoopConfiguration,
    +      options)
    +  }
     }
     
    -class TextOutputWriter(path: String, dataSchema: StructType, context: TaskAttemptContext)
    +/**
    + * Base TextOutputWriter class for 'batch' TextOutputWriter and 'streaming' TextOutputWriter. The
    + * writing logic to a single file resides in this base class.
    + */
    +private[text] abstract class TextOutputWriterBase(context: TaskAttemptContext)
    --- End diff --
    
    This `TextOutputWriterBase` is basically the original `TextOutputWriter`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org