Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: zsxwing <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-13189-spark@git.apache.org>
In-Reply-To: <git-pr-13189-spark@git.apache.org>
Subject: [GitHub] spark pull request #13189: [SPARK-14670][SQL] allow updating
 driver side sql...
Content-Type: text/plain
Message-Id: <20160608184620.6AF5FDFD43@git1-us-west.apache.org>
Date: Wed,  8 Jun 2016 18:46:20 +0000 (UTC)

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13189#discussion_r66315667
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
    @@ -361,17 +374,22 @@ private[spark] class SQLHistoryListener(conf: SparkConf, sparkUI: SparkUI)
     /**
      * Represent all necessary data for an execution that will be used in Web UI.
      */
    -private[ui] class SQLExecutionUIData(
    -    val executionId: Long,
    -    val description: String,
    -    val details: String,
    -    val physicalPlanDescription: String,
    -    val physicalPlanGraph: SparkPlanGraph,
    -    val accumulatorMetrics: Map[Long, SQLPlanMetric],
    -    val submissionTime: Long,
    -    var completionTime: Option[Long] = None,
    -    val jobs: mutable.HashMap[Long, JobExecutionStatus] = mutable.HashMap.empty,
    -    val stages: mutable.ArrayBuffer[Int] = mutable.ArrayBuffer()) {
    +private[ui] case class SQLExecutionUIData(
    --- End diff --
    
    nit: Since you move some fields out of the constructor, it should not be a case class. Most of the generated methods, e.g., `toString`, `hashCode`, `equals` won't work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org