Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: gatorsmile <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-9162-spark@git.apache.org>
In-Reply-To: <git-pr-9162-spark@git.apache.org>
Subject: [GitHub] spark pull request #9162: [SPARK-10655][SQL] Adding
 additional data type map...
Content-Type: text/plain
Message-Id: <20160603223334.0A80FDFD4C@git1-us-west.apache.org>
Date: Fri,  3 Jun 2016 22:33:34 +0000 (UTC)

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9162#discussion_r65785335
  
    --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DB2IntegrationSuite.scala ---
    @@ -47,19 +49,20 @@ class DB2IntegrationSuite extends DockerJDBCIntegrationSuite {
         conn.prepareStatement("INSERT INTO tbl VALUES (17,'dave')").executeUpdate()
     
         conn.prepareStatement("CREATE TABLE numbers ( small SMALLINT, med INTEGER, big BIGINT, "
    -      + "deci DECIMAL(31,20), flt FLOAT, dbl DOUBLE)").executeUpdate()
    +      + "deci DECIMAL(31,20), flt FLOAT, dbl DOUBLE, real REAL, decflt DECFLOAT)").executeUpdate()
    --- End diff --
    
    How about `DECFLOAT(16)` and `DECFLOAT(34)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org