spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dafrista <...@git.apache.org>
Subject [GitHub] spark pull request #13676: [SPARK-15956] [SQL] When unwrapping ORC avoid pat...
Date Wed, 15 Jun 2016 00:43:39 GMT
GitHub user dafrista opened a pull request:

    https://github.com/apache/spark/pull/13676

    [SPARK-15956] [SQL] When unwrapping ORC avoid pattern matching at runtime

    ## What changes were proposed in this pull request?
    
    Extend the returning of unwrapper functions from primitive types to all types.
    
    ## How was this patch tested?
    
    The patch should pass all unit tests. Reading ORC files with non-primitive types with
this change reduced the read time by ~15%.
    
    ===
    
    The github diff is very noisy. Attaching the screenshots below for improved readability:
    
    ![screen shot 2016-06-14 at 5 33 16 pm](https://cloud.githubusercontent.com/assets/1514239/16064580/4d6f7a98-3257-11e6-9172-65e4baff948b.png)
    
    ![screen shot 2016-06-14 at 5 33 28 pm](https://cloud.githubusercontent.com/assets/1514239/16064587/5ae6c244-3257-11e6-8460-69eee70de219.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dafrista/spark improve-orc-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13676.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13676
    
----
commit bdd188546c6043b694e2b1e023a4e78f1e5fffdb
Author: Brian Cho <bcho@fb.com>
Date:   2016-06-13T20:36:17Z

    Avoid pattern matching in runtime when unwrapping ORC.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message