spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ericl <...@git.apache.org>
Subject [GitHub] spark pull request #13586: [SPARK-15860] Metrics for codegen size and perf
Date Fri, 10 Jun 2016 02:36:06 GMT
GitHub user ericl opened a pull request:

    https://github.com/apache/spark/pull/13586

    [SPARK-15860] Metrics for codegen size and perf

    ## What changes were proposed in this pull request?
    
    Adds codahale metrics for the codegen source text size and how long it takes to compile.
The size is particularly interesting, since the JVM does have hard limits on how large methods
can get.
    
    To simplify, I added the metrics under a statically-initialized source that is always
registered with SparkEnv.
    
    ## How was this patch tested?
    
    Unit tests


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ericl/spark spark-15860

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13586.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13586
    
----
commit ddd36cfa05de2e6c9cbfbd31b70d66b8c32660a8
Author: Eric Liang <ekl@databricks.com>
Date:   2016-06-10T02:27:18Z

    Thu Jun  9 19:27:18 PDT 2016

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message