spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #13487: [MINOR][SQL] Update testsuites/comments/error mes...
Date Fri, 03 Jun 2016 00:39:12 GMT
GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/13487

    [MINOR][SQL] Update testsuites/comments/error messages about Tungsten/SortBasedAggregate.

    ## What changes were proposed in this pull request?
    
    For consistency, this PR updates some remaining `TungstenAggregation/SortBasedAggregate`
after SPARK-15728.
    - Update a comment in codegen in `VectorizedHashMapGenerator.scala`.
    - `TungstenAggregationQuerySuite` --> `HashAggregationQuerySuite`
    - `TungstenAggregationQueryWithControlledFallbackSuite` --> `HashAggregationQueryWithControlledFallbackSuite`
    - Update two error messages in `SQLQuerySuite.scala` and `AggregationQuerySuite.scala`.
    - Update several comments.
    
    ## How was this patch tested?
    
    Manual (Only comment changes and test suite renamings).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-15744

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13487.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13487
    
----
commit 345b1916d8a6dcfc05c2b4958aec71e21138e3e5
Author: Dongjoon Hyun <dongjoon@apache.org>
Date:   2016-06-03T00:21:55Z

    [MINOR][SQL] Update testsuites/comments/error messages about Tungsten/SortBasedAggregate.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message