spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request #13503: [SPARK-15761] [MLlib] [PySpark] Load ipython when...
Date Thu, 30 Jun 2016 19:11:41 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13503#discussion_r69192597
  
    --- Diff: bin/pyspark ---
    @@ -52,7 +52,7 @@ fi
     
     # Determine the Python executable to use for the executors:
     if [[ -z "$PYSPARK_PYTHON" ]]; then
    -  if [[ $PYSPARK_DRIVER_PYTHON == *ipython* && $DEFAULT_PYTHON != "python2.7"
]]; then
    +  if [[ $PYSPARK_DRIVER_PYTHON == *ipython* && $DEFAULT_PYTHON < "python2.7"
]]; then
    --- End diff --
    
    That said, the code in this PR is a strict improvement over the old overly-stringent check,
so it's okay to merge it in its current form but I'd prefer to just make this super robust
so we fix this once and for all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message