spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #13982: [SPARK-16304] LinkageError should not crash Spark...
Date Thu, 30 Jun 2016 06:42:08 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13982#discussion_r69079309
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -1872,6 +1872,12 @@ private[spark] object Utils extends Logging {
         }
       }
     
    +  /** Returns true if the given exception is a linkage error. */
    +  def isLinkageError(e: Throwable): Boolean = e match {
    +    case _: java.lang.LinkageError => true
    --- End diff --
    
    This can just be `e.instanceOf[LinkageError]` but an entire method for this is not appropriate


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message