spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BryanCutler <...@git.apache.org>
Subject [GitHub] spark pull request #13428: [SPARK-12666][CORE] SparkSubmit packages fix for ...
Date Wed, 29 Jun 2016 16:27:24 GMT
Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13428#discussion_r68980204
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -891,10 +891,12 @@ private[spark] object SparkSubmitUtils {
         val localIvy = new FileSystemResolver
         val localIvyRoot = new File(ivySettings.getDefaultIvyUserDir, "local")
         localIvy.setLocal(true)
    -    localIvy.setRepository(new FileRepository(localIvyRoot))
    --- End diff --
    
    It's redundant because the filesystem patterns defined below use an absolute path (with
the `localIvyRoot`) and the resolver then ignores the repository root set here.  Only if it
determines the patterns are using relative paths it will then prefix them with the root. 
 It doesn't hurt anything to leave it in though, if you prefer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message