spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From petermaxlee <...@git.apache.org>
Subject [GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function
Date Wed, 29 Jun 2016 07:01:56 GMT
Github user petermaxlee commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13966#discussion_r68894703
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
    @@ -162,6 +162,42 @@ case class ConcatWs(children: Seq[Expression])
       }
     }
     
    +@ExpressionDescription(
    +  usage = "_FUNC_(n, str1, str2, ...) - returns the n-th string",
    +  extended = "> SELECT _FUNC_(1, 'scala', 'java') FROM src LIMIT 1;\n" + "'scala'")
    +case class Elt(children: Seq[Expression])
    +  extends Expression with ExpectsInputTypes with CodegenFallback {
    +
    +  require(children.nonEmpty, "elt requires at least one argument.")
    --- End diff --
    
    I updated this to use super.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message