spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request #13929: [SPARK-16220][SQL] Add scope to show functions
Date Mon, 27 Jun 2016 23:59:34 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13929#discussion_r68677782
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
    @@ -841,21 +841,29 @@ class SessionCatalog(
       }
     
       /**
    -   * List all functions in the specified database, including temporary functions.
    +   * List all functions in the specified database, including temporary functions. This
    +   * returns the function identifier and the scope in which it was defined (system or
user
    +   * defined).
        */
    -  def listFunctions(db: String): Seq[FunctionIdentifier] = listFunctions(db, "*")
    +  def listFunctions(db: String): Seq[(FunctionIdentifier, String)] = listFunctions(db,
"*")
    --- End diff --
    
    this is hacky, but ok for 2.0.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message