spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request #13603: [SPARK-15865][CORE] Blacklist should not result i...
Date Mon, 27 Jun 2016 19:43:36 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13603#discussion_r68642421
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
    @@ -30,6 +30,7 @@ import org.apache.spark.annotation.DeveloperApi
     @DeveloperApi
     class TaskInfo(
         val taskId: Long,
    +    /** the index of this task in its TaskSet.  *Not* necessarily the same as the partitionid
*/
    --- End diff --
    
    Ah ok got it.  I saw one of your earlier comments but wasn't sure how to interpret what
was striked-through in it.  Since this is in the developer (so semi-user-facing), what about
changing this comment to: "The index of this task within its task set. Not necessarily the
same as the ID of the RDD partition that the task is computing."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message