spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #13765: [SPARK-16052][SQL] Add `CollapseRepartitionBy` op...
Date Mon, 27 Jun 2016 13:41:58 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13765#discussion_r68577644
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
    @@ -547,6 +548,16 @@ object CollapseRepartition extends Rule[LogicalPlan] {
     }
     
     /**
    + * Combines adjacent [[RepartitionByExpression]] operators.
    + */
    +object CollapseRepartitionBy extends Rule[LogicalPlan] {
    +  def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
    +    case RepartitionByExpression(exprs, RepartitionByExpression(_, child, _), numPartitions)
=>
    --- End diff --
    
    I think we can add more cases:
    ```
    case RepartitionByExpression(exprs, Repartition(_, _, child), numPartitions) =>
      RepartitionByExpression(exprs, child, numPartitions)
    case Repartition(numPartitions, _, r: RepartitionByExpression) =>
      r.copy(numPartitions = numPartitions)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message