spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <>
Subject [GitHub] spark pull request #13680: [SPARK-15962][SQL] Introduce implementation with ...
Date Mon, 27 Jun 2016 08:26:24 GMT
Github user cloud-fan commented on a diff in the pull request:
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/
    @@ -25,17 +25,21 @@
     import org.apache.spark.sql.types.*;
     import org.apache.spark.unsafe.Platform;
     import org.apache.spark.unsafe.array.ByteArrayMethods;
    +import org.apache.spark.unsafe.bitset.BitSetMethods;
     import org.apache.spark.unsafe.hash.Murmur3_x86_32;
     import org.apache.spark.unsafe.types.CalendarInterval;
     import org.apache.spark.unsafe.types.UTF8String;
      * An Unsafe implementation of Array which is backed by raw memory instead of Java objects.
    - * Each tuple has three parts: [numElements] [offsets] [values]
    + * Each tuple has three four: [numElements] [null bits] [values] [variable length portion]
    --- End diff --
    [values] -> [values or offset]?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message