spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaceklaskowski <...@git.apache.org>
Subject [GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...
Date Sun, 26 Jun 2016 18:05:35 GMT
Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13909#discussion_r68506637
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala
---
    @@ -26,6 +26,20 @@ import org.apache.spark.sql.test.SharedSQLContext
     class DataFrameComplexTypeSuite extends QueryTest with SharedSQLContext {
       import testImplicits._
     
    +  test("primitive type on array") {
    +    val df = sparkContext.parallelize(Seq(1, 2), 1).toDF("v")
    +    val resDF = df.selectExpr("Array(v + 2, v + 3)")
    +    checkAnswer(resDF,
    +      Seq(Row(Array(3, 4)), Row(Array(4, 5))))
    +  }
    +
    +  test("primitive type and null on array") {
    +    val df = sparkContext.parallelize(Seq(1, 2), 1).toDF("v")
    +    val resDF = df.selectExpr("Array(v + 2, null, v + 3)")
    +    checkAnswer(resDF,
    +      Seq(Row(Array(3, null, 4)), Row(Array(4, null, 5))))
    +  }
    +
       test("UDF on struct") {
         val f = udf((a: String) => a)
    --- End diff --
    
    `val f = udf[String, String](identity)` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message