spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #13867: [SPARK-16161][SQL] Ambiguous error message for un...
Date Sat, 25 Jun 2016 02:17:02 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13867#discussion_r68482400
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -911,19 +911,30 @@ class Analyzer(
          * Resolve the correlated expressions in a subquery by using the an outer plans'
references. All
          * resolved outer references are wrapped in an [[OuterReference]]
          */
    -    private def resolveOuterReferences(plan: LogicalPlan, outer: LogicalPlan): LogicalPlan
= {
    +    private def resolveOuterReferences(
    +        plan: LogicalPlan,
    +        outers: Seq[LogicalPlan]): LogicalPlan = {
    +      var throwError = false
           plan transformDown {
             case q: LogicalPlan if q.childrenResolved && !q.resolved =>
               q transformExpressions {
                 case u @ UnresolvedAttribute(nameParts) =>
                   withPosition(u) {
                     try {
    -                  outer.resolve(nameParts, resolver) match {
    +                  val outer = outers.iterator
    +                  var expr: Option[NamedExpression] = None
    --- End diff --
    
    `var expo = Option.empty[NamedExpression]`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message