spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #13758: [SPARK-16043][SQL] Prepare GenericArrayData imple...
Date Fri, 24 Jun 2016 17:49:59 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13758#discussion_r68434992
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala
---
    @@ -142,3 +196,227 @@ class GenericArrayData(val array: Array[Any]) extends ArrayData
{
         result
       }
     }
    +
    +final class GenericIntArrayData(val primitiveArray: Array[Int]) extends GenericArrayData
{
    +  override def array(): Array[Any] = primitiveArray.toArray
    +
    +  override def copy(): GenericIntArrayData = new GenericIntArrayData(primitiveArray.clone())
    +
    +  override def numElements(): Int = primitiveArray.length
    +
    +  override def isNullAt(ordinal: Int): Boolean = false
    +  override def getInt(ordinal: Int): Int = primitiveArray(ordinal)
    +  override def toIntArray(): Array[Int] = {
    --- End diff --
    
    Nit: `primitiveArray.clone()`? Or use `toIntArray` in `copy()`...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message