spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext wi...
Date Tue, 21 Jun 2016 23:35:26 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13380#discussion_r67972054
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
    @@ -116,6 +129,9 @@ abstract class MLWriter extends BaseReadWrite with Logging {
       }
     
       // override for Java compatibility
    +  override def session(sparkSession: SparkSession): this.type = super.session(sparkSession)
    +
    +  // override for Java compatibility
       override def context(sqlContext: SQLContext): this.type = super.context(sqlContext)
    --- End diff --
    
    Just realized: Can you please change this to call ```super.session(sqlContext.sparkSession)```
to avoid a deprecation warning?  Same for the other call to context() below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message