spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request #13688: [HOTFIX] [CORE] fix flaky BasicSchedulerIntegrati...
Date Wed, 15 Jun 2016 22:03:49 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13688#discussion_r67254547
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/SchedulerIntegrationSuite.scala
---
    @@ -518,10 +518,11 @@ class BasicSchedulerIntegrationSuite extends SchedulerIntegrationSuite[SingleCor
     
           // make sure the required map output is available
           task.stageId match {
    -        case 1 => assertMapOutputAvailable(b)
    -        case 3 => assertMapOutputAvailable(c)
             case 4 => assertMapOutputAvailable(d)
    -        case _ => // no shuffle map input, nothing to check
    +        case _ =>
    +        // we can't check for the output for the two intermediate stages, unfortunately,
    +        // b/c the stage numbering is non-deterministic, so stage number alone doesn't
tell
    +        // us what to check
    --- End diff --
    
    I thought about this, but decided it was kind of silly since you could be checking for
something irrelevant, and its not a trivial change (you'd need to catch an exception from
doing the wrong check).  Anyway just figured I'd leave it out for the hotfix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message