spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ueshin <...@git.apache.org>
Subject [GitHub] spark pull request #13638: [SPARK-15915][SQL] CacheManager should use canoni...
Date Mon, 13 Jun 2016 23:03:58 GMT
Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13638#discussion_r66884468
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
    @@ -155,8 +156,9 @@ private[sql] class CacheManager extends Logging {
        * function will over invalidate.
        */
       private[sql] def invalidateCache(plan: LogicalPlan): Unit = writeLock {
    +    val canonicalized = plan.canonicalized
         cachedData.foreach {
    -      case data if data.plan.collect { case p if p.sameResult(plan) => p }.nonEmpty
=>
    +      case data if data.plan.collect { case p if p.sameResult(canonicalized) => p
}.nonEmpty =>
    --- End diff --
    
    I see, I'll fix them, too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message