spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zzcclp <...@git.apache.org>
Subject [GitHub] spark pull request #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregato...
Date Mon, 13 Jun 2016 01:48:35 GMT
Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13619#discussion_r66732825
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
    @@ -390,6 +390,18 @@ class AFTSurvivalRegressionSuite
         testEstimatorAndModelReadWrite(aft, datasetMultivariate,
           AFTSurvivalRegressionSuite.allParamSettings, checkModelData)
       }
    +
    +  test("SPARK-15892: Incorrectly merged AFTAggregator with zero total count") {
    +    // This `dataset` will contain an empty partition because it has two rows but
    +    // the parallelism is bigger than that. Because the issue was about `AFTAggregator`s
    +    // being merged incorrectly when it has an empty partition, running the codes below
    +    // should not throw an exception.
    +    val dataset = spark.createDataFrame(
    --- End diff --
    
    I compile it in branch-1.6.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message