spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #13596: [SPARK-15870][SQL] DataFrame can't execute after ...
Date Sat, 11 Jun 2016 03:51:07 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13596#discussion_r66700295
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
    @@ -321,7 +321,8 @@ class CachedTableSuite extends QueryTest with SQLTestUtils with SharedSQLContext
         assert(spark.sharedState.cacheManager.isEmpty)
       }
     
    -  test("Clear accumulators when uncacheTable to prevent memory leaking") {
    +  // This test would be flaky.
    +  ignore("Ensure accumulators to be cleared after GC when uncacheTable") {
    --- End diff --
    
    how about we attach a listener to `ContextCleaner`, and watch the `accumCleaned` event?
an example is: https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala#L406-L417


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message