spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ericl <...@git.apache.org>
Subject [GitHub] spark pull request #13161: [SPARK-14851] [Core] Support radix sort with null...
Date Fri, 10 Jun 2016 21:14:00 GMT
Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13161#discussion_r66681990
  
    --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/RadixSort.java
---
    @@ -205,13 +210,14 @@ public static int sortKeyPrefixArray(
        * getCounts with some added parameters but that seems to hurt in benchmarks.
        */
       private static long[][] getKeyPrefixArrayCounts(
    -      LongArray array, int numRecords, int startByteIndex, int endByteIndex) {
    +      LongArray array, int startIndex, int numRecords, int startByteIndex, int endByteIndex)
{
         long[][] counts = new long[8][];
         long bitwiseMax = 0;
         long bitwiseMin = -1L;
    -    long limit = array.getBaseOffset() + numRecords * 16;
    +    long baseOffset = array.getBaseOffset() + startIndex * 8;
    --- End diff --
    
    Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message