spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sameeragarwal <...@git.apache.org>
Subject [GitHub] spark pull request #13161: [SPARK-14851] [Core] Support radix sort with null...
Date Fri, 10 Jun 2016 17:17:57 GMT
Github user sameeragarwal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13161#discussion_r66649155
  
    --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
    @@ -93,6 +94,14 @@ public int compare(RecordPointerAndKeyPrefix r1, RecordPointerAndKeyPrefix
r2) {
       private int pos = 0;
     
       /**
    +   * If sorting with radix sort, specifies the starting position in the sort buffer where
records
    +   * with non-null prefixes are kept. Positions [0..nullPos) will contain null-prefixed
records,
    +   * and positions [nullPos..pos) non-null prefixed records. This lets us avoid radix
sorting
    +   * over null values.
    +   */
    +  private int nullPos = 0;
    --- End diff --
    
    minor nit: would something `nullBoundary` or `nullBoundaryPos` better imply the semantics?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message