spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request #13342: [SPARK-15593][SQL]Add DataFrameWriter.foreach to ...
Date Thu, 09 Jun 2016 23:42:28 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13342#discussion_r66541111
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ForeachSinkSuite.scala
---
    @@ -0,0 +1,149 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.streaming
    +
    +import java.util.concurrent.ConcurrentLinkedQueue
    +
    +import scala.collection.mutable
    +
    +import org.apache.spark.sql.ForeachWriter
    +import org.apache.spark.sql.streaming.StreamTest
    +import org.apache.spark.sql.test.SharedSQLContext
    +
    +class ForeachSinkSuite extends StreamTest with SharedSQLContext {
    +
    +  import testImplicits._
    +
    +  test("foreach") {
    +    ForeachWriterEvent.clear()
    +    withTempDir { checkpointDir =>
    +      val input = MemoryStream[Int]
    +      val query = input.toDS().repartition(2).write
    +        .option("checkpointLocation", checkpointDir.getCanonicalPath)
    +        .foreach(new ForeachWriter[Int] {
    +
    +          private val events = mutable.ArrayBuffer[ForeachWriterEvent.Event]()
    +
    +          override def open(partitionId: Long, version: Long): Boolean = {
    +            events += ForeachWriterEvent.Open(partition = partitionId, version = version)
    +            true
    +          }
    +
    +          override def process(value: Int): Unit = {
    +            events += ForeachWriterEvent.Process(value)
    +          }
    +
    +          override def close(errorOrNull: Throwable): Unit = {
    +            events += ForeachWriterEvent.Close(error = Option(errorOrNull))
    +            ForeachWriterEvent.addEvents(events)
    +          }
    +        })
    +      input.addData(1, 2, 3, 4)
    +      query.processAllAvailable()
    +
    +      val expectedEventsForPartition0 = Seq(
    +        ForeachWriterEvent.Open(partition = 0, version = 0),
    +        ForeachWriterEvent.Process(value = 1),
    +        ForeachWriterEvent.Process(value = 3),
    +        ForeachWriterEvent.Close(None)
    +      )
    +      val expectedEventsForPartition1 = Seq(
    +        ForeachWriterEvent.Open(partition = 1, version = 0),
    +        ForeachWriterEvent.Process(value = 2),
    +        ForeachWriterEvent.Process(value = 4),
    +        ForeachWriterEvent.Close(None)
    +      )
    +
    +      val allEvents = ForeachWriterEvent.allEvents()
    +      assert(allEvents.size === 2)
    +      assert {
    +        allEvents === Seq(expectedEventsForPartition0, expectedEventsForPartition1) ||
    +          allEvents === Seq(expectedEventsForPartition1, expectedEventsForPartition0)
    +      }
    +      query.stop()
    +    }
    +  }
    +
    +  test("foreach error") {
    --- End diff --
    
    nit: foreach with error


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message